fix(s3): add missing if-none-match request field#7420
Closed
dentiny wants to merge 1 commit intoapache:mainfrom
Closed
fix(s3): add missing if-none-match request field#7420dentiny wants to merge 1 commit intoapache:mainfrom
dentiny wants to merge 1 commit intoapache:mainfrom
Conversation
dosubot
Bot
added
size:XS
Xuanwo
requested changes
Apr 21, 2026
| req = req.header(IF_MATCH, if_match); | ||
| } | ||
|
|
||
| if let Some(if_none_match) = args.if_none_match() { |
Member
There was a problem hiding this comment.
This is wrong because AWS S3 doesn't support input except *
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7419
Rationale for this change
All request field in the S3 request should be supported.
What changes are included in this PR?
This PR adds missing if-none-match field in S3 requests.
Are there any user-facing changes?
No.
AI Usage Statement
Cursor helped me auto-complete code.